Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly track the status #821

Merged
merged 5 commits into from
Oct 26, 2023
Merged

Properly track the status #821

merged 5 commits into from
Oct 26, 2023
+29 −58

Conversation

imobachgs
Copy link
Contributor

Problem

After the refactoring of the providers, it might happen that the <LoadingEnvironment> component does not detect the status changes.

Solution

  • Move the status changes detection to the <App> component, just like the phase tracking.
  • Get rid of the <LoadingEnvironment> component. After all, it was just a <Loading> with status tracking.

Testing

  • Adapted the unit tests.
  • Tested manually.

@coveralls
Copy link

Coverage Status

coverage: 75.163% (+0.04%) from 75.125% when pulling 494bb5a on fix-loading into b5920ac on master.

jreidinger
jreidinger approved these changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@jreidinger jreidinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dropping code is always good

@imobachgs imobachgs merged commit ff4fc26 into master Oct 26, 2023
10 checks passed
@imobachgs imobachgs deleted the fix-loading branch October 26, 2023 22:42
@imobachgs imobachgs mentioned this pull request Oct 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreidinger jreidinger jreidinger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@imobachgs @coveralls @jreidinger